search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Bundled libraries #416

Open hannes101 opened 4 years ago

hannes101 commented 4 years ago

I am in the process of getting the tilda package re-reviewed to be available in fedora 32. During the review process a couple of issues came up with regard to coupled libraries and their licenses. I think this should be rather straightforward to fix. Issues:

Please see the bugzilla downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1830220

lanoxx commented 4 years ago

Could you explain how to solve this and what in your opinion needs to be done here? This code has already been in tilda before I started maintaining it and it has never been a problem on Debian.

I have done a quick code search according to the results there is also a version of the tomboykeybinder source and header files that are licensed under "LGPLv2.1 or later". So I think I will replace the header of these two files to "LGPLv2.1 or later" to ensure we have a consistent use of the GPL license family.

Here are some additional notes about this:

The code was written by Alex Graveley in 2004 and added to tomboy, since Tomboy was licensed under LGPLv2 or later that the time, it means the code was first licensed as LGPLv2. Four years later the code was relicensed to MIT/X11. Since you cannot revoke the GPL licenses it means the code is now licensed under LGPVv2.1 or later as well as the MIT/X11 license.

I hope that helps.

LyesSaadi commented 4 years ago

Well, I don't really think there's a way to solve this?

I see that you modified those files? I don't know if it's only updates or structural changes. If it's the last one, then it is just impossible to unbundle them...

If this issue was opened it is mostly because it's required by Fedora's Guidelines to do so, and if you don't have a way to unbundle those libraries, it's fine.

Have you any idea from where eggaccelerator.c/.h is though ?

lanoxx commented 4 years ago

The eggaccelerator.c/.h are also from Tomboy see commit https://github.com/tomboy-notes/tomboy/commit/68636cbf13f6b97621374d50cffb63e577036794#diff-825290606dd2aa71f7dd2a7641edff06 But the code might have originated somewhere else, I have seen parts of that source code in glib before.