search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.26k stars 162 forks source link

Prepend PATH= to Fix VTE assertion error. #438

Closed KevinMoonglow closed 3 years ago

KevinMoonglow commented 3 years ago

Prepends "PATH=" to the value returned by getenv("PATH"). This fixes an assertion error in the VTE library that prevents the terminal from spawning when using a custom command.

Fixes #435

agb80 commented 3 years ago

Could you help us to review and merger @lanoxx?

alanmcg commented 3 years ago

Tested this patch myself and it works well, thank you!

lanoxx commented 3 years ago

To everyone who has commented here and in the duplicate issues. Thanks a lot for reporting this and thanks to @KevinMoonglow for providing the fix. I have just merged the pull request (with slightly modified commit message).

In order to get this into distributions I will need to make a new release of tilda and backport this fix. For Debian testing that should not be a big problem, but for Ubuntu 20.10 a stable release update will be necessary. If I find the time I will try to do that.

I anyone wants to help speed this up, then please check this link and use the SRU Bug template to file an SRU bug on Launchpad against the tilda package: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

lanoxx commented 3 years ago

By the way, this issue was introduced by the following commit in VTE: https://gitlab.gnome.org/GNOME/vte/-/commit/9697d30cead63dfba031d3547140668535395540