search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 160 forks source link

Segmentation fault when custom command is set #504

Closed elig0n closed 1 year ago

elig0n commented 1 year ago

whether empty or not, setting any custom command (with/without login shell option checked) shows this crash:

(tilda:822217): VTE-CRITICAL **: 16:03:19.525: void vte_pty_spawn_with_fds_async(VtePty*, const char*, const char* const*, const char* const*, const int*, int, const int*, int, GSpawnFlags, GSpawnChildSetupFunc, gpointer, GDestroyNotify, int, GCancellable*, GAsyncReadyCallback, gpointer): assertion 'envv == nullptr || _vte_pty_check_envv(envv)' failed
[1]    822217 segmentation fault (core dumped)  tilda

tilda 1.5.4 on Manjaro Linux.

lanoxx commented 1 year ago

Thanks, any chance you could attach a debugger like gdb and submit a backtrace?

lanoxx commented 1 year ago

While there was one change in 1.5.4 related to command spawning, which can found in commit d377fbba4d7706e96d9872c7c3b582089eda558b, I don't think that would have caused a regression, or we would have probably seen more reports.

lanoxx commented 1 year ago

On second thought it looks like you are observing an issue which was fixed by this #481 and commit 51a980a55ad6d750daa21d43a66d44577dad277b,

A quick search through the git history (via git log -L 530,540:../src/tilda_terminal.c) shows that this bug was introduced by me in commit 42139b7ec41d7fa168d7beff54a1a7b3bffccc79 (in 2015). My apologies for this mistake.

I have cherry-picked this to the tilda-1-5 branch and tagged a 1.5.5 release in git. I am not sure how this can find its way into Manjaro Linux.

lanoxx commented 1 year ago

Relevant commit on tilda-1-5 branch is: d09139e65f69ce5a3634458b187839692ee10716

lanoxx commented 1 year ago

If you can still reproduce this with in the mentioned fix, then please reopen this issue.