lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.28k stars 161 forks source link

Option to select how pull-up behave on non-focused terminal #88

Closed sudaraka closed 10 years ago

sudaraka commented 10 years ago

Note: The new behavior of pull-up was interrupting my usual workflow for two reasons.

  1. When I have Tilda open in workspace A and I'm on workspace B, hitting pull-up key twice used to bring the Tilda to current workspace. But now it switch me to workspace A because of the Tilda window being focused.
  2. I used to launch GUI application from the command like (i.e gvim, gitk, etc.) and if I feel I need space for the application (in a tiling WM) I hit the pull-up key to hide the Tilda window while in the newly launched application. New behavior takes the focus out of my working application which is not what I need.

I understand that other may prefer the new new behavior, therefor I made this patch so that user can choose which behavior they would like Tilda to have.

lanoxx commented 10 years ago

The patch looks good. I am just curious why you used a dropdown instead of a checkbox? I will review it more thoroughly when I have time on the weekend and then I am going to merge it. Thank you for the patch.

sudaraka commented 10 years ago

On 09/17/14 12:40, Sebastian Geiger wrote:

I am just curious why you used a dropdown instead of a checkbox?

Only reason I used a dropdown is because I can explain the function better with the text in it. Let me know if you want to change it to a checkbox, I'm open about that.

Also, please check the wording as well (I'm not a native English speaker).

Thanks.

lanoxx commented 10 years ago

Closing. Merged.

lanoxx commented 10 years ago

There was still a quirk with the labels, fixed it with: b9d325ea4c9034b6701080d5149b24132072f957

sudaraka commented 10 years ago

Thanks