lanpa / tensorboardX

tensorboard for pytorch (and chainer, mxnet, numpy, ...)
https://tensorboardx.readthedocs.io/en/latest/tensorboard.html
MIT License
7.87k stars 863 forks source link

Use matplotlib's agg backend in test_figure.py. #706

Closed tjni closed 1 year ago

tjni commented 1 year ago

By default, matplotlib will use an interactive backend when it detects that one is available. This is both unnecessary and, in some cases, can break builds.

One example of a build breaking is on macOS Ventura when these tests are run using a non-root user (such as a user used for builds) that is not the logged-in user. The interactive macOS backend crashes with an error in _xpc_api_misuse when creating an NSWindow, likely due to some tighter security requirements.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (d75a89b) 84.75% compared to head (751821c) 84.79%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #706 +/- ## ========================================== + Coverage 84.75% 84.79% +0.04% ========================================== Files 36 36 Lines 2105 2105 ========================================== + Hits 1784 1785 +1 + Misses 321 320 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/lanpa/tensorboardX/pull/706/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tzu-Wei+Huang)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lanpa commented 1 year ago

Thanks!