search

lanpa / tensorboardX

tensorboard for pytorch (and chainer, mxnet, numpy, ...)
https://tensorboardx.readthedocs.io/en/latest/tensorboard.html
MIT License
7.85k stars 865 forks source link

Fix: make writer fw_tag windows compatible #721

Closed DumbMice closed 10 months ago

DumbMice commented 10 months ago

In add_scalars, fw_tag is actually a path, which should be handled by os.path.join(str(fw_logdir), main_tag, tag) rather than fw_logdir+'/'+ main_tag+'/'+ tag which only works on unix systems.

This fix bugs which might occur on windows platform.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
tensorboardX/writer.py 86.41% <100.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

lanpa commented 10 months ago

Thank you!