search

lansingcodes / www

Events and resources for Lansing coders
https://www.lansing.codes
Other
7 stars 16 forks source link

OpenGraph tags #87

Closed jamierytlewski closed 5 years ago

jamierytlewski commented 5 years ago

Why does the OpenGraph tag have an SVG for the image? I know SVG images are "cleaner", but many sites (Twitter, MS Teams, iMessage) do not support SVG's for the images.

egillespie commented 5 years ago

Hi @jamierytlewski, sorry for taking a while to respond. I was buried in student code reviews in April and missed the notification of your issue.

You make a great point and I wanted to let you know that a new version of the website was launched this morning. The OpenGraph image tag now points at a binary image instead of an SVG. I plan to make a better and optimized version of the image down the road, but at least moving forward more sites will be able to unfurl the website.

Thanks for the recommendation! 👍

jamierytlewski commented 5 years ago

Erik,

Thanks for the reply. I had actually forgot about the issue. Thanks for following up. Good luck. Jamie

On Tue, Jun 4, 2019 at 11:37 AM Erik Gillespie notifications@github.com wrote:

Closed #87 https://github.com/lansingcodes/www/issues/87.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lansingcodes/www/issues/87?email_source=notifications&email_token=AAFJ3HXT5NOLEFN3XY3E6ILPY2D3PA5CNFSM4HGWSSSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORZPOQKQ#event-2388584490, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFJ3HSLQSO3XFBHZOMRPQTPY2D3PANCNFSM4HGWSSSA .