Closed MontaltoNick closed 1 month ago
The changes involve significant renaming and restructuring across multiple files in the reporting service, focusing on updating class names, modifying data types for Kafka producers and consumers, and removing deprecated functionalities. The updates aim to clarify the purpose of various classes and streamline the reporting logic, particularly in relation to report scheduling and submission.
Files | Change Summary |
---|---|
DotNet/Report/Application/Extensions/KafkaProducerRegistration.cs |
Renamed type parameters for Kafka producer factories from SubmissionReportKey /SubmissionReportValue to SubmitReportKey /SubmitReportValue . |
DotNet/Report/Application/Models/*.cs |
Renamed classes from MeasureReportScheduledKey to ReportScheduledKey , MeasureReportScheduledValue to ReportScheduledValue , and others similarly. |
DotNet/Report/Controllers/ReportController.cs |
Removed MeasureReportSubmissionBundler dependency and the GetSubmissionBundle method, simplifying the controller. |
DotNet/Report/Core/PatientReportSubmissionBundler.cs |
Updated field and parameter types to reflect new report scheduling manager and renamed references accordingly. |
DotNet/Report/Domain/*.cs |
Changed repository types from MeasureReportScheduleModel to ReportScheduleModel , removing deprecated repositories. |
DotNet/Report/Domain/Managers/ReportScheduledManager.cs |
Introduced a new manager for handling report schedules with updated methods for retrieving and managing schedules. |
DotNet/Report/Listeners/*.cs |
Updated Kafka message handling to use new key and value types, reflecting the changes in report scheduling. |
DotNet/Report/Program.cs |
Updated service registrations to use new report scheduling classes and removed deprecated listeners. |
DotNet/Submission/Application/Models/PatientReportSubmissionModel.cs |
Renamed class from MeasureReportSubmissionModel to PatientReportSubmissionModel . |
DotNet/Submission/Listeners/SubmitReportListener.cs |
Changed variable type from MeasureReportSubmissionModel to PatientReportSubmissionModel in the CreatePatientBundleFiles method. |
sequenceDiagram
participant User
participant ReportController
participant PatientReportSubmissionBundler
participant ReportScheduledManager
participant KafkaProducer
User->>ReportController: Request report submission
ReportController->>PatientReportSubmissionBundler: Process submission
PatientReportSubmissionBundler->>ReportScheduledManager: Retrieve report schedule
ReportScheduledManager->>KafkaProducer: Produce report message
KafkaProducer-->>User: Confirmation of submission
Objective | Addressed | Explanation |
---|---|---|
Remove deprecated functionality and adjust misleading names (LNK-2741) | ✅ | |
Update naming conventions for clarity (LNK-2741) | ✅ | |
Streamline report scheduling logic (LNK-2741) | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
https://lantana.atlassian.net/browse/LNK-2741
Summary by CodeRabbit
New Features
ReportScheduledManager
for managing report schedules.CreateOrganization
method to streamline the creation of FHIR-compliant organization entities.Renaming
MeasureReportScheduledKey
toReportScheduledKey
andMeasureReportSubmissionModel
toPatientReportSubmissionModel
.Bug Fixes
Refactor
ReportController
by removing unnecessary dependencies and methods.