lantanagroup / link-cloud

1 stars 1 forks source link

LNK-2769 Normalization ResourceAcquired Changes #467

Closed MontaltoNick closed 2 weeks ago

MontaltoNick commented 3 weeks ago

https://lantana.atlassian.net/browse/LNK-2769

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The pull request introduces significant changes to the Data Acquisition and Query Dispatch domains. Key modifications include the replacement of the ReportType property with a new Type property of the QueryPlanType enumeration in the QueryPlan class, as well as the addition of a ReportableEvent property to various message classes. The changes also involve updates to database migrations, service methods, and configurations to support these new properties and improve event handling.

Changes

Files Change Summary
DotNet/DataAcquisition.Domain/Entities/QueryPlan.cs Replaced ReportType with Type of QueryPlanType.
DotNet/DataAcquisition.Domain/Migrations/20240905164852_RemoveReportTypeFromQueryPlanAndAddType.* Migration to remove ReportType column and add Type column in the database schema.
DotNet/DataAcquisition.Domain/Models/QueryPlanType.cs Introduced QueryPlanType enumeration.
DotNet/DataAcquisition/Application/Managers/QueryPlanManager.cs Updated UpdateAsync method to use Type instead of ReportType.
DotNet/Normalization/Application/Models/Messages/ResourceAcquiredMessage.cs Added ReportableEvent property.
DotNet/Normalization/Application/Models/Messages/ResourceNormalizedMessage.cs Added ReportableEvent property.
DotNet/Normalization/Application/Models/Messages/ScheduledReport.cs Replaced ReportType with ReportTypes array and added Frequency property.
DotNet/QueryDispatch/Application/Models/DataAcquisitionRequestedValue.cs Added ReportableEvent property.
DotNet/QueryDispatch/Application/Models/Frequency.cs Introduced Frequency enumeration.
DotNet/QueryDispatch/Application/Models/ReportScheduledValue.cs Modified to remove Parameters and add ReportTypes, Frequency, StartDate, and EndDate.
DotNet/Report/Application/Models/ReportScheduledValue.cs Modified to remove Parameters and add ReportTypes, Frequency, StartDate, and EndDate.
DotNet/Report/Application/Models/SubmitReportKey.cs Added ReportScheduleId property.
DotNet/Report/Controllers/ReportController.cs Modified to use reportScheduleId instead of date parameters.
DotNet/Report/Core/PatientReportSubmissionBundler.cs Modified to require reportScheduleId instead of date parameters.
DotNet/Submission/Application/Models/SubmitReportKey.cs Added ReportScheduleId property.

Assessment against linked issues

Objective Addressed Explanation
Successfully consume and produce events containing the new ReportableEvent field (LNK-2769)

Possibly related issues

Possibly related PRs

[!TIP]

OpenAI O1 model for chat - We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.