Closed MontaltoNick closed 2 weeks ago
The pull request introduces significant changes to the Data Acquisition and Query Dispatch domains. Key modifications include the replacement of the ReportType
property with a new Type
property of the QueryPlanType
enumeration in the QueryPlan
class, as well as the addition of a ReportableEvent
property to various message classes. The changes also involve updates to database migrations, service methods, and configurations to support these new properties and improve event handling.
Files | Change Summary |
---|---|
DotNet/DataAcquisition.Domain/Entities/QueryPlan.cs |
Replaced ReportType with Type of QueryPlanType . |
DotNet/DataAcquisition.Domain/Migrations/20240905164852_RemoveReportTypeFromQueryPlanAndAddType.* |
Migration to remove ReportType column and add Type column in the database schema. |
DotNet/DataAcquisition.Domain/Models/QueryPlanType.cs |
Introduced QueryPlanType enumeration. |
DotNet/DataAcquisition/Application/Managers/QueryPlanManager.cs |
Updated UpdateAsync method to use Type instead of ReportType . |
DotNet/Normalization/Application/Models/Messages/ResourceAcquiredMessage.cs |
Added ReportableEvent property. |
DotNet/Normalization/Application/Models/Messages/ResourceNormalizedMessage.cs |
Added ReportableEvent property. |
DotNet/Normalization/Application/Models/Messages/ScheduledReport.cs |
Replaced ReportType with ReportTypes array and added Frequency property. |
DotNet/QueryDispatch/Application/Models/DataAcquisitionRequestedValue.cs |
Added ReportableEvent property. |
DotNet/QueryDispatch/Application/Models/Frequency.cs |
Introduced Frequency enumeration. |
DotNet/QueryDispatch/Application/Models/ReportScheduledValue.cs |
Modified to remove Parameters and add ReportTypes , Frequency , StartDate , and EndDate . |
DotNet/Report/Application/Models/ReportScheduledValue.cs |
Modified to remove Parameters and add ReportTypes , Frequency , StartDate , and EndDate . |
DotNet/Report/Application/Models/SubmitReportKey.cs |
Added ReportScheduleId property. |
DotNet/Report/Controllers/ReportController.cs |
Modified to use reportScheduleId instead of date parameters. |
DotNet/Report/Core/PatientReportSubmissionBundler.cs |
Modified to require reportScheduleId instead of date parameters. |
DotNet/Submission/Application/Models/SubmitReportKey.cs |
Added ReportScheduleId property. |
Objective | Addressed | Explanation |
---|---|---|
Successfully consume and produce events containing the new ReportableEvent field (LNK-2769) |
✅ |
ReportScheduleId
, which aligns with the objective of simplifying querying for patient bundles.PatientDataService.cs
, which relates to handling data acquisition requests, indicating a potential overlap in functionality.[!TIP]
OpenAI O1 model for chat
- We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
https://lantana.atlassian.net/browse/LNK-2769
Summary by CodeRabbit
New Features
QueryPlanType
enumeration for enhanced query plan categorization.Frequency
property to scheduled reports for better scheduling options.ReportableEvent
property added to various message classes for improved event tracking.Bug Fixes
Refactor
Chores