search

lantanagroup / link-cloud

1 stars 1 forks source link

LNK-2507: Cleanup Submission Service Tech Debt #480

Closed MontaltoNick closed 1 week ago

MontaltoNick commented 1 week ago

🛠 Description of Changes

Please provide a high-level overview of the changes included in this PR.

Cleanup unused DB items, classes, old authorization files, configs, data models, etc.

🧪 Testing Performed:

Please describe the testing that was performed on the changes included in this PR.

Service start up and Kafka Message Receivable to SubmitReportListener

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request involves the complete removal of several files related to tenant submission management, including the ITenantSubmissionManager interface and its implementing class TenantSubmissionManager. Additionally, multiple classes and interfaces associated with authentication and database context management have been deleted. The changes streamline the codebase by eliminating unused or unnecessary components, impacting the overall structure of the submission service.

Changes

File Path Change Summary
DotNet/Submission/Application/Interfaces/ITenantSubmissionManager.cs Interface ITenantSubmissionManager removed.
DotNet/Submission/Application/Managers/TenantSubmissionManager.cs Class TenantSubmissionManager and its methods removed.
DotNet/Submission/Application/Models/ApiModels/Method.cs Class Method removed.
DotNet/Submission/Application/Models/CensusAdmittedPatient.cs Class CensusAdmittedPatient removed.
DotNet/Submission/Application/Models/FileSystemConfig.cs Class FileSystemConfig removed.
DotNet/Submission/Application/Services/Auth/BasicAuth.cs Class BasicAuth and its method SetAuthentication removed.
DotNet/Submission/Application/Services/Interfaces/IAuth.cs Interface IAuth and its method SetAuthentication removed.
DotNet/Submission/Domain/Entities/TenantSubmissionConfigEntity.cs Class TenantSubmissionConfigEntity removed.
DotNet/Submission/Domain/Models/AuthenticationConfiguration.cs Class AuthenticationConfiguration removed.
DotNet/Submission/Domain/SubmissionEntityRepository.cs Class SubmissionEntityRepository<T> removed.
DotNet/Submission/Domain/TenantSubmissionDbContext.cs Class TenantSubmissionDbContext removed.
DotNet/Submission/Infrastructure/SubmissionHealthCheck.cs Class SubmissionHealthCheck and its method CheckHealthAsync removed.
DotNet/Submission/Listeners/SubmitReportListener.cs Unused using directives removed.
DotNet/Submission/Migrations/20240610170909_202406101308_Initial.Designer.cs Migration file removed.
DotNet/Submission/Migrations/20240610170909_202406101308_Initial.cs Migration class removed.
DotNet/Submission/Migrations/TenantSubmissionDbContextModelSnapshot.cs Model snapshot removed.
DotNet/Submission/Program.cs Service registrations and configurations for database context, health checks, and Swagger removed.
DotNet/Submission/Settings/SubmissionConstants.cs Constants DatabaseProvider and DatabaseConnectionString removed.
DotNet/Submission/Submission.csproj Removed entries for Domain\Interfaces from project file.

Assessment against linked issues

Objective Addressed Explanation
Refactor submission service to use ServiceRegistry (LNK-2507) ❌ The pull request does not indicate any refactoring to use ServiceRegistry.

Possibly related PRs

Suggested reviewers

:scroll: Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
:inbox_tray: Commits Files that changed from the base of the PR and between 790d4cb844d6f96a2b2c03a7c9c30dfcdb60cf2f and 33b16b55201129460e22c7b55b9c636c800c0e00.
:ledger: Files selected for processing (19) * DotNet/Submission/Application/Interfaces/ITenantSubmissionManager.cs (0 hunks) * DotNet/Submission/Application/Managers/TenantSubmissionManager.cs (0 hunks) * DotNet/Submission/Application/Models/ApiModels/Method.cs (0 hunks) * DotNet/Submission/Application/Models/CensusAdmittedPatient.cs (0 hunks) * DotNet/Submission/Application/Models/FileSystemConfig.cs (0 hunks) * DotNet/Submission/Application/Services/Auth/BasicAuth.cs (0 hunks) * DotNet/Submission/Application/Services/Interfaces/IAuth.cs (0 hunks) * DotNet/Submission/Domain/Entities/TenantSubmissionConfigEntity.cs (0 hunks) * DotNet/Submission/Domain/Models/AuthenticationConfiguration.cs (0 hunks) * DotNet/Submission/Domain/SubmissionEntityRepository.cs (0 hunks) * DotNet/Submission/Domain/TenantSubmissionDbContext.cs (0 hunks) * DotNet/Submission/Infrastructure/SubmissionHealthCheck.cs (0 hunks) * DotNet/Submission/Listeners/SubmitReportListener.cs (0 hunks) * DotNet/Submission/Migrations/20240610170909_202406101308_Initial.Designer.cs (0 hunks) * DotNet/Submission/Migrations/20240610170909_202406101308_Initial.cs (0 hunks) * DotNet/Submission/Migrations/TenantSubmissionDbContextModelSnapshot.cs (0 hunks) * DotNet/Submission/Program.cs (0 hunks) * DotNet/Submission/Settings/SubmissionConstants.cs (0 hunks) * DotNet/Submission/Submission.csproj (0 hunks)
:zzz: Files not reviewed due to no reviewable changes (19) * DotNet/Submission/Application/Interfaces/ITenantSubmissionManager.cs * DotNet/Submission/Application/Managers/TenantSubmissionManager.cs * DotNet/Submission/Application/Models/ApiModels/Method.cs * DotNet/Submission/Application/Models/CensusAdmittedPatient.cs * DotNet/Submission/Application/Models/FileSystemConfig.cs * DotNet/Submission/Application/Services/Auth/BasicAuth.cs * DotNet/Submission/Application/Services/Interfaces/IAuth.cs * DotNet/Submission/Domain/Entities/TenantSubmissionConfigEntity.cs * DotNet/Submission/Domain/Models/AuthenticationConfiguration.cs * DotNet/Submission/Domain/SubmissionEntityRepository.cs * DotNet/Submission/Domain/TenantSubmissionDbContext.cs * DotNet/Submission/Infrastructure/SubmissionHealthCheck.cs * DotNet/Submission/Listeners/SubmitReportListener.cs * DotNet/Submission/Migrations/20240610170909_202406101308_Initial.Designer.cs * DotNet/Submission/Migrations/20240610170909_202406101308_Initial.cs * DotNet/Submission/Migrations/TenantSubmissionDbContextModelSnapshot.cs * DotNet/Submission/Program.cs * DotNet/Submission/Settings/SubmissionConstants.cs * DotNet/Submission/Submission.csproj
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
:heart: Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
:placard: Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.