search

lantanagroup / link-cloud

1 stars 1 forks source link

LNK-3015: Merge Dev into Multi Measure #482

Closed MontaltoNick closed 1 week ago

MontaltoNick commented 1 week ago

🛠 Description of Changes

Please provide a high-level overview of the changes included in this PR.

🧪 Testing Performed

Please describe the testing that was performed on the changes included in this PR.

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes involve modifications to the QueryPlan class, including the removal of the ReportType property and the introduction of a new Type property of the QueryPlanType enumeration. Additionally, several migration files were created or updated to reflect these changes in the database schema. Other adjustments include updates to various services and models to accommodate the new structure, as well as the introduction of properties related to reportable events in multiple classes.

Changes

Files Change Summary
DotNet/DataAcquisition.Domain/Entities/QueryPlan.cs Removed ReportType, added Type (of type QueryPlanType).
DotNet/DataAcquisition.Domain/Migrations/*.cs Created migration to remove ReportType and add Type (int).
DotNet/DataAcquisition.Domain/Migrations/DataAcquisitionDbContextModelSnapshot.cs Updated model snapshot to reflect removal of ReportType and addition of Type.
DotNet/DataAcquisition.Domain/Models/QueryPlanType.cs Introduced QueryPlanType enumeration with members Monthly, Weekly, Daily, Discharge.
DotNet/DataAcquisition/Application/Managers/QueryPlanManager.cs Updated UpdateAsync method to use Type instead of ReportType.
DotNet/DataAcquisition/Application/Services/PatientDataService.cs Modified logic to compare Type instead of ReportType.
DotNet/Normalization/Application/Models/Messages/*.cs Added ReportableEvent property to ResourceAcquiredMessage and ResourceNormalizedMessage.
DotNet/Normalization/Application/Models/Messages/ScheduledReport.cs Replaced ReportType with ReportTypes (array of strings) and added Frequency.
DotNet/QueryDispatch/Application/Models/*.cs Added ReportableEvent to DataAcquisitionRequestedValue and introduced Frequency enumeration.
DotNet/QueryDispatch/Application/Factory/QueryDispatchFactory.cs Updated CreateScheduledReport method to include a new frequency parameter.
DotNet/QueryDispatch/Application/Interfaces/IQueryDispatchFactory.cs Updated method signature for CreateScheduledReport to include frequency.
DotNet/QueryDispatch/Application/Extensions/KafkaRegistration.cs Changed key type from ReportScheduledKey to string in Kafka consumer and producer factories.
DotNet/Normalization/Listeners/ResourceAcquiredListener.cs Added validation for ReportableEvent and included it in audit event parameters.

Assessment against linked issues

Objective Addressed Explanation
Merge Dev Into Multi Measure (LNK-3015) ✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
:placard: Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.