lanterndata / lantern

PostgreSQL vector database extension for building AI applications
https://lantern.dev
GNU Affero General Public License v3.0
790 stars 57 forks source link

Set module extension to dylib for mac and postgres 16 #165

Closed var77 closed 1 year ago

var77 commented 1 year ago

In Postgres 16 the file extension for shared libraries of extension is changed from .so to .dylib, I have added a check in Cmake to apply corresponding file extension based on Postgres version and Platform. Also did necessary changes in packaging scripts. closes #164

dqii commented 1 year ago

Do you want to fix the README to do

[![build](https://github.com/lanterndata/lantern/actions/workflows/build.yaml/badge.svg?branch=main)](https://github.com/lanterndata/lantern/actions/workflows/build.yaml)
[![test](https://github.com/lanterndata/lantern/actions/workflows/test.yaml/badge.svg?branch=main)](https://github.com/lanterndata/lantern/actions/workflows/test.yaml)

too?

github-actions[bot] commented 1 year ago

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 0.00%
recall (after insert) 0.784 0.784 0.00%
select bulk tps 132.100 174.262 31.92%
select bulk latency (ms) 59.491 45.107 -24.18%
select bulk latency (stddev ms) 9.195 8.813 -4.15%
create latency (ms) 1705.212 1447.475 -15.11%
insert bulk tps 6.849 9.997 45.97%
insert bulk latency (ms) 145.992 100.012 -31.49%
insert bulk latency (stddev ms) 6.444 3.133 -51.38%
disk usage (bytes) 6348800.000 6348800.000 0.00%
var77 commented 1 year ago

Do you want to fix the README to do

[![build](https://github.com/lanterndata/lantern/actions/workflows/build.yaml/badge.svg?branch=main)](https://github.com/lanterndata/lantern/actions/workflows/build.yaml)
[![test](https://github.com/lanterndata/lantern/actions/workflows/test.yaml/badge.svg?branch=main)](https://github.com/lanterndata/lantern/actions/workflows/test.yaml)

too?

Changed them! Thanks for pointing it out!

dqii commented 1 year ago

It seems like the CI/CD doesn't show up because the last commit was [skip ci]?

var77 commented 1 year ago

It seems like the CI/CD doesn't show up because the last commit was [skip ci]?

Yes the latest built was successful, I just changed the README in the last commit, so added [skip ci] to not trigger CI as no code was changed there.

var77 commented 1 year ago

This closes #164