lanterndata / lantern

PostgreSQL vector database extension for building AI applications
https://lantern.dev
GNU Affero General Public License v3.0
790 stars 57 forks source link

Support expression-based index operator checks #179

Closed dqii closed 1 year ago

Ngalstyan4 commented 1 year ago

@var77 , it seems code coverage does not run even when just benchmarking fails. Can we make it so that code coverage runs as long as build succeeds and tests pass?

var77 commented 1 year ago

@Ngalstyan4 I think there's an issue with codecov not running the checks after we have changed the repo name. Can you try to reinstall the Codecov app and update codecov token in action secrets? Maybe that will fix the issue

codecov[bot] commented 1 year ago

Codecov Report

Merging #179 (6f97a02) into main (40dcf10) will decrease coverage by 1.06%. Report is 7 commits behind head on main. The diff coverage is 63.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ========================================== - Coverage 84.12% 83.06% -1.06% ========================================== Files 18 17 -1 Lines 1165 1175 +10 Branches 245 251 +6 ========================================== - Hits 980 976 -4 Misses 85 85 - Partials 100 114 +14 ``` | [Files](https://app.codecov.io/gh/lanterndata/lantern/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanterndata) | Coverage Δ | | |---|---|---| | [src/hooks/executor\_start.c](https://app.codecov.io/gh/lanterndata/lantern/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanterndata#diff-c3JjL2hvb2tzL2V4ZWN1dG9yX3N0YXJ0LmM=) | `89.47% <0.00%> (ø)` | | | [src/hooks/post\_parse.c](https://app.codecov.io/gh/lanterndata/lantern/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanterndata#diff-c3JjL2hvb2tzL3Bvc3RfcGFyc2UuYw==) | `89.87% <66.66%> (-5.52%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/lanterndata/lantern/pull/179/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lanterndata)
github-actions[bot] commented 1 year ago

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.748 0.750 +0.27%
select bulk tps 195.864 225.659 +15.21%
select bulk latency (ms) 38.565 34.764 -9.86%
select bulk latency (stddev ms) 12.361 7.369 -40.39%
create latency (ms) 1518.336 1464.022 -3.58%
insert bulk tps 12.235 14.702 +20.16%
insert bulk latency (ms) 81.713 68.001 -16.78%
insert bulk latency (stddev ms) 3.270 2.241 -31.47%
disk usage (bytes) 6348800.000 6348800.000 -