lanterndata / lantern

PostgreSQL vector database extension for building AI applications
https://lantern.dev
GNU Affero General Public License v3.0
790 stars 57 forks source link

Enable dynamic undefined symbols in shared libraries on Apple #76

Closed Ngalstyan4 closed 1 year ago

Ngalstyan4 commented 1 year ago

The default in new mac systems seems to be that undefined symbols are allowed in shared libraries. This is the default in linux systems as well.

So far we assumed all mac systems allow undefined symbols in shared libraries. But that is not the case and old linkers need the extra flag

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (97700fd) into main (b9aedd5) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 83.02% 83.02% ======================================= Files 11 11 Lines 854 854 Branches 161 161 ======================================= Hits 709 709 Misses 66 66 Partials 79 79 ```
smmuirhead100 commented 1 year ago

Was having trouble with installation, but this fixed it. Thanks!