search

lanthaler / JsonLD

JSON-LD processor for PHP
MIT License
336 stars 61 forks source link

use cURL if available in FileGetContentsLoader #68

Closed cKlee closed 8 years ago

cKlee commented 8 years ago

This solves https://github.com/lanthaler/JsonLD/issues/67. It checks whether function curl_init exists and uses cURL then instead of file_get_contents.

lanthaler commented 8 years ago

Sorry for the late reply @cKlee. Could you please put this in a separate class CurlLoad instead of putting it into FileGetContentsLoader. The latter is called that way because it uses file_get_contents(). Also, now that PSR-7 (see issue #4) has been released, it would be possible to refactor this so that it would become very simple to use all sorts of libraries.

cKlee commented 8 years ago

Further discussion at https://github.com/lanthaler/JsonLD/issues/4