search

lanthaler / JsonLD

JSON-LD processor for PHP
MIT License
335 stars 62 forks source link

Rename Object to JsonLDObject (Fix PHP 7.2) #92

Closed whikloj closed 5 years ago

whikloj commented 6 years ago

Similar to #79 but doesn't switch back to use stdClass() but instead changes the old Object name to JsonLDObject. Also fixes two locations where arrays were assumed for uses of count() but tests fail.

This is also starting to hit the limits of using PHPUnit 4, I'd recommend dropping some of the older versions of PHP from the support matrix.

whikloj commented 6 years ago

Of interest to @acoburn and @DiegoPino

osma commented 6 years ago

+1. We are also struggling with 7.2 compatibility, merging this into an official release available via Composer would help a lot!

whikloj commented 6 years ago

@lanthaler If there is something I can do to make this easier, please let me know. I realize that you may not want to use JsonLDObject and I have no issue changing that if it helps you.

rdewaele commented 5 years ago

We also encountered this problem while using api-platform with this plugin to generate the PHP classes. @lanthaler Could you share an update on reviewing and/or merging this PR?

Mehrdad-Dadkhah commented 5 years ago

same problem, please merge this PR

whikloj commented 5 years ago

Hi @lanthaler,

6 months in and there has been no response on this PR. Is there something I can do to help move this forward?

DiegoPino commented 5 years ago

@lanthaler I know you are very busy dealing with JSON-LD 1.1 specs and your day job too, but it would mean a great deal to us == highly appreciated == if you could review/merge this pull. Many of us are using this package (great one) on current and future larger community-driven Open Source projects and having PHP 7.2 support is crucial. Thanks!

osma commented 5 years ago

Yay, finally! Thanks a lot @lanthaler!

DiegoPino commented 5 years ago

@lanthaler++ thanks a lot

whikloj commented 5 years ago

Thank you @lanthaler, I would have been happy to make the desired changes but either way I am glad to get this working. Cheers.

lanthaler commented 5 years ago

No worries. I had a couple of hours and wanted to get as much done as possible :-) Thanks for the PR and the patience