search

lantins / dns-zone

A Ruby library for building and parsing DNS zone files.
MIT License
22 stars 13 forks source link

Further fixes for a quote enclosed semicolon when loading the DNS string #2

Closed ahukkanen closed 10 years ago

ahukkanen commented 10 years ago

Did not think #1 fully through.

This fixes the problem in that pull request also when loading the DNS string.

Sorry, I was too quick and did not realize that the lines are also striped with the same method (did not expect this but should have checked first).

Also added some additional tests for loading from a string.

Further question: should the gsubbing be done in a central location instead of 3 separate locations?

lantins commented 10 years ago

I'm glad you noticed this @ahukkanen :)

RE: gsubbing

Adding validation and other 'Nice to have' features from the README is going to require a reshuffle of the code, IIRC I decided to hold off the refactoring until at least validation was added.

But this was a while ago... I could of just wrote some sloppy code :)

ahukkanen commented 10 years ago

OK, great to hear refactoring is on the roadmap.

Just a note, though. There are very few things in life in general that are perfect anyways. ;)

lantins commented 10 years ago

True, true ;)

lantins commented 10 years ago

v0.1.3 pushed to RubyGems