search

lantins / resque-lock-timeout

A Resque plugin; adds locking, with optional timeout/deadlock handling to resque jobs.
MIT License
53 stars 20 forks source link

Loner jobs #13

Closed ssaunier closed 11 years ago

ssaunier commented 11 years ago

Hi @lantins,

I added the @loner boolean option to prevent the same job to be enqueued if one is already running/enqueued.

I hope it suits you.

Thanks.

ssaunier commented 11 years ago

Apparently I broke something in rbx-18mode. I am new to that, What should I do? Thanks. https://travis-ci.org/lantins/resque-lock-timeout/builds/3125794

lantins commented 11 years ago

@ssaunier Awesome, awesome, awesome :)

Just took a quick look at the changes, it looks solid, especially as you've done the documentation. I'll pull down your changes and test them out here, not too sure why you're getting errors with rbx-18mode, I'll take a look.

Will let you know if I have any questions/comments.

Luke

ssaunier commented 11 years ago

Thanks!

I saw you merged it. Did you figure out the rbx-18mode issue to fix the continous integration?

lantins commented 11 years ago

After merging CI passed, I didn't change anything, guess solar rays hit the machine last time?

I'm just making a couple of tweaks to the documentation, will see what happens to the CI after another test run.

Thank you very much for your efforts & pull request, you've done a fantastic job, very much a pleasure to receive.

If the rbx issue has gone away, I'll release v0.4.0 to RubyGems.

ssaunier commented 11 years ago

Great! Looking foward to the 0.4.0 :)

lantins commented 11 years ago

After quite a few test runs on Travis, rbx is behaving.

v0.4.0 gem pushed and available.

Merci beaucoup :)

Luke