search

lantins / resque-lock-timeout

A Resque plugin; adds locking, with optional timeout/deadlock handling to resque jobs.
MIT License
53 stars 20 forks source link

README: clarify identifier section. #8

Closed henrik closed 12 years ago

henrik commented 12 years ago

The "resque-lock-timeout" prefix is not actually in use. Example of "redis_lock_key".

lantins commented 12 years ago

Thanks for fixing up my poor english and comment typos =)

lantins commented 12 years ago

I do ponder if the prefix should be changed to what the comment suggested it was? But on the other hand, there's already a good amount of people using it with the lock prefix without issue, so perhaps its good enough?

Any thoughts about this before I merge your pull request?

henrik commented 12 years ago

I think keeping "lock" should be fine. It's what resque-lock uses.

On 12 jan 2012, at 20:53, Luke Antinsreply@reply.github.com wrote:

I do ponder if the prefix should be changed to what the comment suggested it was? But on the other hand, there's already a good amount of people using it with the lock prefix without issue, so perhaps its good enough?

Any thoughts about this before I merge your pull request?

Reply to this email directly or view it on GitHub: https://github.com/lantins/resque-lock-timeout/pull/8#issuecomment-3469366

henrik commented 12 years ago

No problem. Thanks for the lib!

On 12 jan 2012, at 20:51, Luke Antinsreply@reply.github.com wrote:

Thanks for fixing up my poor english and comment typos =)

Reply to this email directly or view it on GitHub: https://github.com/lantins/resque-lock-timeout/pull/8#issuecomment-3469335

lantins commented 12 years ago

Thanks for your input, I'm happy to leave it as it is.

Pull request merged.