search

lantunes / cellpylib

A library for working with Cellular Automata, for Python.
https://cellpylib.org
Apache License 2.0
228 stars 32 forks source link

[JOSS] Use of deprecated `np.int` #22

Closed blsqr closed 3 years ago

blsqr commented 3 years ago

Running the tests emits a large number (>600) of warnings, most of which stem from the use of np.int in the init_… functions. np.int is simply an alias to the builtin Python int and – as of numpy 1.20 – np.int is deprecated.

You can simply replace it with int to address the warnings. Alternatively, you may want to use the precision limited (but perhaps faster) np.int64, np.int32…

lantunes commented 3 years ago

Thanks @blsqr! I have made some changes to address the warnings emitted while running the tests. I no longer see any warnings. The changes are in the joss_review branch, and this issue will be closed when that branch is merged into master.

blsqr commented 3 years ago

Perfect! 👍

lantunes commented 3 years ago

For reference, the relevant commit is 1850b3c1676e0bb55752d617158741d5c371d9aa.