lantus / devilution-nx

Diablo for the Nintendo Switch
The Unlicense
859 stars 61 forks source link

Virtual keyboard support, control improvements, cutscene audio #17

Closed rsn8887 closed 5 years ago

rsn8887 commented 5 years ago

This PR includes the following fixes

Closes #5

rsn8887 commented 5 years ago

Tested and ready to merge.

rsn8887 commented 5 years ago

Tested keyboard etc.

Ready to merge @lantus :)

rsn8887 commented 5 years ago

Ok tested and ready to merge again.

lantus commented 5 years ago

testing now.

rsn8887 commented 5 years ago

I got cutscene audio to work one sec

rsn8887 commented 5 years ago

Ok I just tested it with the new cutscene audio fix. Works fine.

rsn8887 commented 5 years ago

I made another change with cutscene audio. In the case the audio device would fail to open for a cutscene, it could have crashed, but not anymore.

I think this is complete now. Ready to merge.

AJenbo commented 5 years ago

Nice job getting things cleaned up, I think we can start working on upstreaming things once this is merged.

rsn8887 commented 5 years ago

It should work fine on other devices I think. I don't think there's any harm in some additional Mix_CloseAudio() and Mix_OpenAudio() calls, but I only tested it on Switch.

Has cutscene audio been a known bug on other devices, too?

AJenbo commented 5 years ago

Haven't had issues, but this looks reasonable, honestly i was surprised it wasn't needed. on other devices

lantus commented 5 years ago

Looks good. Merging