Closed rsn8887 closed 5 years ago
Tested and ready to merge.
Tested keyboard etc.
Ready to merge @lantus :)
Ok tested and ready to merge again.
testing now.
I got cutscene audio to work one sec
Ok I just tested it with the new cutscene audio fix. Works fine.
I made another change with cutscene audio. In the case the audio device would fail to open for a cutscene, it could have crashed, but not anymore.
I think this is complete now. Ready to merge.
Nice job getting things cleaned up, I think we can start working on upstreaming things once this is merged.
It should work fine on other devices I think. I don't think there's any harm in some additional Mix_CloseAudio() and Mix_OpenAudio() calls, but I only tested it on Switch.
Has cutscene audio been a known bug on other devices, too?
Haven't had issues, but this looks reasonable, honestly i was surprised it wasn't needed. on other devices
Looks good. Merging
This PR includes the following fixes
Closes #5