lantus / devilution-nx

Diablo for the Nintendo Switch
The Unlicense
859 stars 61 forks source link

Implement touch controls, improve button mapping #24

Closed rsn8887 closed 5 years ago

rsn8887 commented 5 years ago

This PR does the following:

rsn8887 commented 5 years ago

Ready to merge @lantus (note the updated readme.md, it now specifically says to hold R over game and not use album to launch Diablo, to make the keyboard work, same as in @erfg12 latest PR).

rsn8887 commented 5 years ago

It seems this PR already fixes the issues from PR #23 . So that one might not be needed anymore.

erfg12 commented 5 years ago

Doesn't compile: ``c:/devkitpro/devkita64/bin/../lib/gcc/aarch64-none-elf/8.3.0/../../../../aarch64-none-elf/bin/ld.exe: obj/misc_msg.o: in functiondvl::PeekMessageA(dvl::tagMSG, void, unsigned int, unsigned int, unsigned int)': misc_msg.cpp:(.text+0x2c4): undefined reference to `switch_finish_simulated_mouse_clicks(int, int)' collect2.exe: error: ld returned 1 exit status make: *** [makefile:96: release/diablo-nx.elf] Error 1

lantus commented 5 years ago

does not build for me, please correct

rsn8887 commented 5 years ago

One sec. I can fix this.

rsn8887 commented 5 years ago

Ok I think I fixed it all. Sorry for the confusion :)

rsn8887 commented 5 years ago

Ready to merge @lantus @erfg12 thank you for your patience :)

lantus commented 5 years ago

testing, then will merge shortly

rsn8887 commented 5 years ago

Awesome!

rsn8887 commented 5 years ago

I improved the code even more:

rsn8887 commented 5 years ago
rsn8887 commented 5 years ago

I am done for now. The improvements in here should warrant an official release after this PR is merged.

rsn8887 commented 5 years ago

Just did one more:

rsn8887 commented 5 years ago

But that's it.

rsn8887 commented 5 years ago

Ready to merge.