lantus / devilution-nx

Diablo for the Nintendo Switch
The Unlicense
859 stars 61 forks source link

Multiplayer Crashes Atmosphere #6

Open lanerobertlane opened 5 years ago

lanerobertlane commented 5 years ago

In addition to the already created keyboard missing issue (so unable to test entering an IP to play multiplayer over TCP/UDP) creating a multiplayer game via loopback crashes Atmosphere.

I don't know if the solution is possible, or if it's worth removing the multiplayer option from the menu to prevent having to reboot the console.

AJenbo commented 5 years ago

Does this happen as soon as you start the game or after quitting?

lanerobertlane commented 5 years ago

To reproduce:

Choose Multiplayer from the menu, Choose Loopback, (The other options require entering an IP address or a Password, which can't happen without the On Screen Keyboard) Select difficulty,

Then it crashes.

Running Atmosphere 8.0.1

AJenbo commented 5 years ago

Can you check if the two following fixes from upstream resolves the issue: https://github.com/diasurgical/devilutionX/commit/53422694d9ab2522a109a9a9396f8a9460471ad0 https://github.com/diasurgical/devilutionX/commit/27b29a1601e5d3e4260c20391c775efbc6b12624

lanerobertlane commented 5 years ago

I can't make from the source code on Windows, there's dependence like /sys/mman.c in some of the 3rdparty files that aren't available with MSys2. I can only go off the 0.91 release unless there's a buildbot or Nightlys someone that I don't know about.

lantus commented 5 years ago

multiplayer is broken right now. i'll revisit once control issues are resolved

AJenbo commented 5 years ago

Be aware that TCP appears to have broken upstream as of this commit: https://github.com/diasurgical/devilutionX/commit/1d7a548cd72910340131f2c2de9ba7f2fd120b4e It is currently a release blocking issues so should be fixed soon.

lanerobertlane commented 5 years ago

I can't make from the source code on Windows, there's dependence like /sys/mman.c in some of the 3rdparty files that aren't available with MSys2. I can only go off the 0.91 release unless there's a buildbot or Nightlys someone that I don't know about.

Just to update regarding this, the issue in building in Windows is fixed in PR #10