search

laosb / ghos3

A modernized AWS S3 storage adapter for Ghost.
Other
34 stars 12 forks source link

bug fix in urltopath #8

Closed adityapatadia closed 1 year ago

adityapatadia commented 1 year ago

urlToPath function should return actual path without the hostname field. This PR fixes it.

adityapatadia commented 1 year ago

@laosb it would be great if you can merge and release this. Without this, files are stored in weird paths on S3.

laosb commented 1 year ago

Looks good to me, I'll merge now on my phone, and release later.

This is a breaking change, ~though we are still in 0.x~.

Edit: Nevermind, I will release later as 2.0.0 😓.

adityapatadia commented 1 year ago

I have made the required change. Please check once if leading slash is fine or we need to remove it. I could not find any documentation on it.

adityapatadia commented 1 year ago

Hi, This is little bit urgent as our production uploads are stuck. Can you please merge and release. Apologies for the push.

laosb commented 1 year ago

Published as 2.0.0 (with some type check fixes & deps bumped).

Thank you for doing a PR!