search

laozhu / hugo-nuo

🎨 A responsive light & clean hugo theme for blogger.
https://laozhu.me
MIT License
427 stars 150 forks source link

Social media links have no text for screen readers #95

Closed zersiax closed 5 years ago

zersiax commented 5 years ago

Hi,

I actually really like your theme and would love to use it for my blog/personal website. However, the social media icons currently have no textual label for screen readers. Could you have a look at adding this?

laozhu commented 5 years ago

@zersiax Thank you for your suggestion, it's a great suggestion.

I learned a11y from Google and make 100 points with lighthouse a11y audits now.

image

Maybe I will learn something about PWA and support it next time 😂

zersiax commented 5 years ago

All you really need to do is add an aria-label="Twitter", aria-label="Facebook" etc to fix the issue. If you don't have time I can probably make a pull request tomorrow.

laozhu commented 5 years ago

@zersiax fixed, and an aria-hidden="true" to the icon element.

I referred to this great post:

https://fontawesome.com/how-to-use/on-the-web/other-topics/accessibility