lap00zza / 9anime-Companion

:rocket: A simple companion extension for 9anime
https://chrome.google.com/webstore/detail/9anime-companion/fopcehkidabibdmachbcpbgllhehknah
MIT License
89 stars 26 forks source link

Reddit discussion not working for me. #71

Closed Mickymeast closed 7 years ago

Mickymeast commented 7 years ago

Select your issue type: (check at least one)

Describe your issue: Clicking the reddit discussion button searches for an anime's reddit discussion, but no results ever show up, despite when I google search for the discussions, i can find them fine.

lap00zza commented 7 years ago

@Mickymeast I was not able to reproduce this on version 1.0.0. These are the ones I tried with (by try I mean going to a few random episodes on each anime and clicking on reddit discussion):

Can you give me some anime links where clicking on reddit discussion didnt give any results but altering the search query gave results.

@WEBhicham @densityx can you please check it out as well.

lap00zza commented 7 years ago

I tested it on firefox and oddly enough I get search failed. It works properly in my chrome. (I am logged into reddit in chrome and not in firefox).

@Mickymeast I will definitely look into this issue. Thanks for reporting.

lap00zza commented 7 years ago

This seems to be related to #64. This was fixed in 08b473d4d2cf128ca2a996dbc4c27b4960e917fa. And the latest build seems to be working properly (not the released version as this commit was added after release). The latest build can be found in appveyor: https://ci.appveyor.com/project/lap00zza/9anime-Companion/build/artifacts?branch=master and install instructions can be found in https://github.com/lap00zza/9anime-Companion/wiki/Running-in-Developement-Mode.

I am leaving this issue open until I release the next version (with this fix).

Mickymeast commented 7 years ago

I'm on chrome and still have issues, on 1.0.0 The boruto next generation link you provided didn't work until i modified the search so there was a hyphen ( - ) between 'generations' and 'Episode' Same thing with Yuri on Ice, Zero kara Hajimeru Mahou no Shou, Isekai wa Smartphone to Tomo ni. The search for Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu, just resulted in just a complete search failure where it says their servers are too loaded to handle the search. I've tried this on multiple browsers and many times throughout the day, yielding no different results.

Thanks for the help, I'll use the latest build on appveyor from now on.

On Thu, Sep 28, 2017 at 11:38 PM, Jewel Mahanta notifications@github.com wrote:

This seems to be related to #64 https://github.com/lap00zza/9anime-Companion/issues/64. This was fixed in 08b473d https://github.com/lap00zza/9anime-Companion/commit/08b473d4d2cf128ca2a996dbc4c27b4960e917fa. And the latest build seems to be working properly (not the released version as this commit was added after release). The latest build can be found in appveyor: https://ci.appveyor.com/project/lap00zza/9anime- Companion/build/artifacts?branch=master and install instructions can be found in https://github.com/lap00zza/9anime-Companion/wiki/Running- in-Developement-Mode.

I am leaving this issue open until I release the next version (with this fix).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lap00zza/9anime-Companion/issues/71#issuecomment-332839081, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3Nv9eJT_wzfW56Gp6zKwm4Z_8vU3wgks5sm6FygaJpZM4PnMht .

-- Michael Rawson Sunbury College Year 11 VCE Student

Mickymeast commented 7 years ago

Using the latest build on appveyor, the animes I have tested so far work perfectly fine, but Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu still results in a complete search failure. However I suspect that may be to do with something on my end. Thanks again.

On Fri, Sep 29, 2017 at 11:33 PM, Michael Rawson michael.wrawson@gmail.com wrote:

I'm on chrome and still have issues, on 1.0.0 The boruto next generation link you provided didn't work until i modified the search so there was a hyphen ( - ) between 'generations' and 'Episode' Same thing with Yuri on Ice, Zero kara Hajimeru Mahou no Shou, Isekai wa Smartphone to Tomo ni. The search for Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu, just resulted in just a complete search failure where it says their servers are too loaded to handle the search. I've tried this on multiple browsers and many times throughout the day, yielding no different results.

Thanks for the help, I'll use the latest build on appveyor from now on.

On Thu, Sep 28, 2017 at 11:38 PM, Jewel Mahanta notifications@github.com wrote:

This seems to be related to #64 https://github.com/lap00zza/9anime-Companion/issues/64. This was fixed in 08b473d https://github.com/lap00zza/9anime-Companion/commit/08b473d4d2cf128ca2a996dbc4c27b4960e917fa. And the latest build seems to be working properly (not the released version as this commit was added after release). The latest build can be found in appveyor: https://ci.appveyor.com/project/lap00zza/9anime-Companion/ build/artifacts?branch=master and install instructions can be found in https://github.com/lap00zza/9anime-Companion/wiki/Running-in -Developement-Mode.

I am leaving this issue open until I release the next version (with this fix).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lap00zza/9anime-Companion/issues/71#issuecomment-332839081, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3Nv9eJT_wzfW56Gp6zKwm4Z_8vU3wgks5sm6FygaJpZM4PnMht .

-- Michael Rawson Sunbury College Year 11 VCE Student

-- Michael Rawson Sunbury College Year 11 VCE Student

lap00zza commented 7 years ago

@Mickymeast Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu fails in my firefox as well. Looks like the search can be improved. I am labeling this bug again.

Mickymeast commented 7 years ago

Cool, thanks for that.

On Fri, Sep 29, 2017 at 11:46 PM, Jewel Mahanta notifications@github.com wrote:

@Mickymeast https://github.com/mickymeast Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu fails in my firefox as well. Looks like the search can be improved. I am labeling this bug again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lap00zza/9anime-Companion/issues/71#issuecomment-333130572, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae3Nv8AjZ7vB1pa5r5bYoxU3T09pTqwkks5snPSsgaJpZM4PnMht .

-- Michael Rawson Sunbury College Year 11 VCE Student