search

lapaygroup / doctrine-cockroachdb

Doctrine CockroachDB Driver (Symfony supports)
MIT License
11 stars 5 forks source link

Make composer requirements more strict #3

Closed simPod closed 3 years ago

simPod commented 3 years ago

This prevents installing versions that are not supported yet.

iamwildtuna commented 3 years ago

Hello! Thanks for PR.

Why limit doctrine/dbal to version 2? PHP version requirements are described by the doctrine/dbal library used by the consumer.

simPod commented 3 years ago

Because dbal v3 or v4 or v5 will eventually have BC breaks that are not and cannot be handled by the current doctrine-cockroachdb version so it will eventually break consumer applications.

That implies that version ranges should have upper-bound.

iamwildtuna commented 3 years ago

Argument accepted =)

iamwildtuna commented 3 years ago

Added on version 0.1.7.