search

lapo-luchini / asn1js

JavaScript generic ASN.1 parser
ISC License
586 stars 161 forks source link

`TBSCertList` definition missed `version` field #72

Closed Mingun closed 7 months ago

Mingun commented 1 year ago

As you can see in this example of TR-34 Rebind Token, TBSCertList recognized the following fields:

This is wrong, according to RFC 5280 there is an optional version field which is present in the data: ASN 1 JavaScript decoder — Mozilla Firefox_003

(link with example)

lapo-luchini commented 7 months ago

Commit 6f4b911c4f1477e8fd7d3625edd257cbceba0e97 in branch esm has fixed this.

lapo-luchini commented 7 months ago

@Mingun do you know the licensing status of that example? Does it allow re-publishing? (in that case, I'd consider committing it to the "examples" folder of the project)

Mingun commented 7 months ago

Well, this example from the TR-34 specification, which is behind paywall. But I can create another example which will be generated by my program. If you need some formal licensing clause just say what licence you prefer. Or I can made a PR with the example myself, just say me how it should look

lapo-luchini commented 7 months ago

The project uses the ISC license (basically a simpified BSD2), if you agree with that and create a PR that'd be perfect! You can see 826f20ce2e05e13d18ef046cbcb10f6607783dc1 which is a recent commit where I added an example file.

Mingun commented 7 months ago

Ok, I'll prepare a PR next week