laposa / test-portal

Laravel Application integrated with Github Actions
https://laposa.ie
MIT License
1 stars 0 forks source link

Mask credentials in reports and logs #44

Closed norbertlaposa closed 1 month ago

norbertlaposa commented 3 months ago

We need to hide all secrets (passwords, api keys) from all logs. This should happen before saving to the database.

Szkandy commented 1 month ago

Hi @norbertlaposa, can you please give me an example of where this is happening?

norbertlaposa commented 1 month ago

The request from Musgrave states: Run Log should mask user passwords, client secrets, API keys. Can leave user email, RR card# as is to help debug.

This seems to be happening automatically by GitHub: 2024-09-12T11:57:13.6310287Z env: 2024-09-12T11:57:13.6341563Z OP_SERVICE_ACCOUNT_TOKEN: ***

Looks like we are ok, let's close this issue.