Disable delete button when intent has a single text field

lappis-unb / BotFlow

BotFlow - visual content manager for simple Rasa chatbots

GNU General Public License v3.0

30 stars 12 forks source link

Disable delete button when intent has a single text field #151

Open rodmaia opened 3 years ago

rodmaia commented 3 years ago

When an intent has a single text field, the delete button of that text field should be disabled as you cannot leave an intent with zero questions. The delete button should be reenabled once you add more text fields.

Tasks

[x] Steps to complete this task
[x] Steps to complete this task

Acceptance criteria

[x] Delete button is disabled when there is a single text field
[x] Delete button is enabled when there are two or more text fields

Miguel-Alves commented 3 years ago

Reviewing this issue based on #153;

Miguel-Alves commented 3 years ago

This issue was maintained following the procedures of #153;

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

Miguel-Alves commented 3 years ago

Solved this issue as described in #162

rodmaia commented 3 years ago

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

It's not redundant because we are exposing the actual behavior in a way people can understand, following the usability principle of Visibility of the System 😉

Miguel-Alves commented 3 years ago

Got it! Thanks by the answer. It makes total sense. The validation was added, and a PR to solve this issue is open.

rodmaia commented 3 years ago

I tested it! Looks good on my side.