search

lapps / org.lappsgrid.examples

LAPPS example code.
2 stars 3 forks source link

Fix#21 step2 to api2.1.1 #23

Closed keighrim closed 8 years ago

keighrim commented 9 years ago

resolving #21

chunqishi commented 9 years ago

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim notifications@github.com wrote:

resolving #21 https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

chunqishi commented 9 years ago

Hi, Keigh,

You deleted v2.1.1 of edu.brandeis.cs.opennlp-web-service???

Why delete it?

Best.

Chunqi

On Wed, Oct 28, 2015 at 9:10 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim notifications@github.com wrote:

resolving #21 https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

chunqishi commented 9 years ago

Again, which branch should we work on?

Chunqi

On Wed, Oct 28, 2015 at 9:22 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You deleted v2.1.1 of edu.brandeis.cs.opennlp-web-service???

Why delete it?

Best.

Chunqi

On Wed, Oct 28, 2015 at 9:10 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim notifications@github.com wrote:

resolving #21

https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

chunqishi commented 9 years ago

Hi, Keigh,

I totally confused about current version situation.

Should I work on v2.0.1 or should I work on v2.1.1.

If v2.0.1, what feature in v2.1.1 (stanford) that will be only used for next version ?

if v2.1.1, why no v2.1.1 (opennlp) available.

Best,

Chunqi

On Wed, Oct 28, 2015 at 9:24 AM, Chunqi Shi chqshi@gmail.com wrote:

Again, which branch should we work on?

Chunqi

On Wed, Oct 28, 2015 at 9:22 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You deleted v2.1.1 of edu.brandeis.cs.opennlp-web-service???

Why delete it?

Best.

Chunqi

On Wed, Oct 28, 2015 at 9:10 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim notifications@github.com wrote:

resolving #21

https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

keighrim commented 9 years ago

I create stanfordnlp wrapper to 2.1.1 to match the version of org.lappsgrid.all, But as you said, 2.0.1-snapshot is what's on the docker image, so I think we should work on 2.0.1 branch of stanford.

While the opennlp, I didn't updated to 2.1.1 at the firstplace. We made a little fix on it on Saturday, and that was 2.0.1.

But let's work on 2.0.1 for both for the demo.

Best, Keigh.

On Tue, Oct 27, 2015 at 9:25 PM, chunqishi notifications@github.com wrote:

Again, which branch should we work on?

Chunqi

On Wed, Oct 28, 2015 at 9:22 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You deleted v2.1.1 of edu.brandeis.cs.opennlp-web-service???

Why delete it?

Best.

Chunqi

On Wed, Oct 28, 2015 at 9:10 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim notifications@github.com wrote:

resolving #21

https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23#issuecomment-151691617 .

chunqishi commented 9 years ago

I got it.

If the lapps.api is not stable, Keith will upgrade it. Maybe we do not need to create a new branch for that, as we will update to new api soon until everything is stable.

Anyway, let us work together on v2.0.1 :- )

Best,

Chunqi

On Wed, Oct 28, 2015 at 9:32 AM, Keigh Rim notifications@github.com wrote:

I create stanfordnlp wrapper to 2.1.1 to match the version of org.lappsgrid.all, But as you said, 2.0.1-snapshot is what's on the docker image, so I think we should work on 2.0.1 branch of stanford.

While the opennlp, I didn't updated to 2.1.1 at the firstplace. We made a little fix on it on Saturday, and that was 2.0.1.

But let's work on 2.0.1 for both for the demo.

Best, Keigh.

On Tue, Oct 27, 2015 at 9:25 PM, chunqishi notifications@github.com wrote:

Again, which branch should we work on?

Chunqi

On Wed, Oct 28, 2015 at 9:22 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You deleted v2.1.1 of edu.brandeis.cs.opennlp-web-service???

Why delete it?

Best.

Chunqi

On Wed, Oct 28, 2015 at 9:10 AM, Chunqi Shi chqshi@gmail.com wrote:

Hi, Keigh,

You created v2.1.1.

Which version of code should we work on? 2.1.1?

Best regards,

Chunqi

Chunqi

On Mon, Oct 26, 2015 at 10:13 AM, Keigh Rim <notifications@github.com

wrote:

resolving #21

https://github.com/lapps/org.lappsgrid.examples/issues/21

You can view, comment on, or merge this pull request online at:

https://github.com/lapps/org.lappsgrid.examples/pull/23 Commit Summary

  • removed WEB-INF, which will be covered in later step
  • updated pom to meet api 2.1.1
  • cleaned up a few words in README

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23.

— Reply to this email directly or view it on GitHub < https://github.com/lapps/org.lappsgrid.examples/pull/23#issuecomment-151691617

.

— Reply to this email directly or view it on GitHub https://github.com/lapps/org.lappsgrid.examples/pull/23#issuecomment-151692429 .