lapsang-boys / pippi

A modular, extensible and collaborative reverse engineering ecosystem
https://pippi.re
BSD 2-Clause "Simplified" License
7 stars 1 forks source link

wailsapp/wails: update to latest wails (when stable), to include status code as needed by CI #49

Closed mewmew closed 4 years ago

mewmew commented 4 years ago

This issue is just for us to help remember a debugging session. After a git bisect the offending change was in go.mod (and go.sum), namely commit 0d1500dc7465fbf155d34115ca4fe04e92b6486f.

We wanted to update as wailsapp/wails#251 (reporting of status code to OS) since we need the status code to be reported to our CI.

However, updating from wails v0.17.0 (a working stable release) to the latest commit on the develop branch (which contained the PR fix to wailsapp/wails#251) produced broken output from wails. When we later updated wails to the latest tagged release v0.18.2, it turns out that this release also did not output working code (see wailsapp/wails#253).

As such, we will remain on v0.17.0 until the upstream issue in wails has been fixed (wailsapp/wails#253).