search

lapwat / papeer

Scrape the web in the eink era. Convert websites into ebooks and markdown.
https://papeer.tech
GNU General Public License v3.0
234 stars 19 forks source link

fix: Implement filename sanitization in ToMarkdown to support Windows #11

Closed AveryNeumann closed 1 year ago

AveryNeumann commented 1 year ago

I resolved the problem reported in issue #10 on https://github.com/lapwat/papeer.

https://github.com/lapwat/papeer/issues/10

lapwat commented 1 year ago

Thank you for the PR! I am not going to merge it because it is specific to Windows.

You can use the --output option to specify a filename manually.

lapwat commented 1 year ago

In your custom Windows build, you can edit the Filename() function https://github.com/lapwat/papeer/blob/a6ba42f3e19990ebb0e51f35216a44c34a88885a/book/format.go#L15 so it will impact EPUB, Markdown and HTML filenames all at once.