laracasts / Lets-Build-a-Forum-in-Laravel

http://laracasts.com/series/lets-build-a-forum-with-laravel
914 stars 311 forks source link

multiple phpunit errors on brand new installation #23

Open vesper8 opened 7 years ago

vesper8 commented 7 years ago

Just cloned this repo, did created a db composer install npm i cp .env.example .env pa key:generate pa migrate

After registering I notice I can't add a new thread because there are no channels? And there doesn't seem to be a route for adding channels.. nor are there any seeders. So channels need to be added manually? Would be nice if you could accept that PR to add seeders

Furthermore..

Running phpunit I get all these errors:

PHPUnit 6.2.3 by Sebastian Bergmann and contributors.

......E..........E..E.E.............E.............R......         57 / 57 (100%)

Time: 7.92 seconds, Memory: 38.00MB

There were 5 errors:

1) Tests\Feature\CreateThreadsTest::authorized_users_can_delete_threads
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertThat() must be an instance of PHPUnit\Framework\Constraint\Constraint, instance of PHPUnit_Framework_Constraint_Not given, called in /DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php on line 41

/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php:41
/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/tests/Feature/CreateThreadsTest.php:90

2) Tests\Feature\ParticipateInThreadsTest::an_authenticated_user_may_participate_in_forum_threads
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertThat() must be an instance of PHPUnit\Framework\Constraint\Constraint, instance of Illuminate\Foundation\Testing\Constraints\HasInDatabase given, called in /DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php on line 21

/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php:21
/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/tests/Feature/ParticipateInThreadsTest.php:30

3) Tests\Feature\ParticipateInThreadsTest::authorized_users_can_delete_replies
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertThat() must be an instance of PHPUnit\Framework\Constraint\Constraint, instance of PHPUnit_Framework_Constraint_Not given, called in /DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php on line 41

/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php:41
/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/tests/Feature/ParticipateInThreadsTest.php:69

4) Tests\Feature\ParticipateInThreadsTest::authorized_users_can_update_replies
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertThat() must be an instance of PHPUnit\Framework\Constraint\Constraint, instance of Illuminate\Foundation\Testing\Constraints\HasInDatabase given, called in /DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php on line 21

/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php:21
/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/tests/Feature/ParticipateInThreadsTest.php:99

5) Tests\Feature\ActivityTest::it_records_activity_when_a_thread_is_created
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertThat() must be an instance of PHPUnit\Framework\Constraint\Constraint, instance of Illuminate\Foundation\Testing\Constraints\HasInDatabase given, called in /DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php on line 21

/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase.php:21
/DEV/_LARACASTS/Lets-Build-a-Forum-in-Laravel/tests/Unit/ActivityTest.php:25

--

There was 1 risky test:

1) Tests\Unit\ThreadTest::a_thread_notifies_all_registered_subscribers_when_a_reply_is_added
This test did not perform any assertions

ERRORS!
Tests: 57, Assertions: 84, Errors: 5, Risky: 1.
eduPHP commented 7 years ago

Hello, did you try running vendor/bin/phpunit?