laracasts / PHP-Vars-To-Js-Transformer

Transform PHP data to JavaScript.
https://packagist.org/packages/laracasts/utilities
MIT License
2.21k stars 219 forks source link

Fix PHPStorm Intellisense for put() method #117

Open eberkund opened 6 years ago

eberkund commented 6 years ago

PHPStorm complains about passes arguments to a function with no parameters. This is because the put() method uses func_get_args() to dynamically retrieve args from the caller.

screen shot 2018-06-03 at 3 08 08 am

I followed the suggestion on this Stack Overflow answer and it fixes the issue. I am also using Laravel IDE helper.

eberkund commented 6 years ago

With regards to the failing CI checks, this PR removes support for PHP 5.5 which I think is okay given its unsupported at this point so I expect that to fail. And the HVVM check was already broken prior to this it looks like.

rdarcy1 commented 5 years ago

@JeffreyWay would you consider merging this? I find the package very useful and would be great if the static analysis didn't warn for every put() call with an argument. Thanks!

AndreasHerss commented 5 years ago

This would be awesome if it could get merged! 😍

GregMayes commented 4 years ago

Would also love to see this get merged. From a static analysis standpoint, It's a lot more transparent than func_get_args.