search

laradji / zabbix

Zabbix chef cookbook
Apache License 2.0
91 stars 124 forks source link

https access #102

Closed andrewGarson closed 10 years ago

andrewGarson commented 11 years ago

https access under apache, now with a cleaner commit history

andrewGarson commented 11 years ago

@guilhem this is much cleaner, what do you think?

andrewGarson commented 11 years ago

@guilhem @laradji ping?

laradji commented 11 years ago

Hello guys, I'm back from vacation, you can merge this one by yourself. :)

guilhem commented 11 years ago

This patch is good for me.

Maybe You must be sure that key files exists and/or have been generated. Someone may also want to add his own? => change it to an attribute can be great.

But it's only enhancement @andrewGarson if you don't have enough time, you can merge it without any problem.

laradji commented 10 years ago

@andrewGarson @guilhem , the vhost 80 need to have ServerAlias <%= @params[:server_aliases].join(' ')%>

Can you add some attribute PATH for the CRT,KEY,IntermediateCA ?

andrewGarson commented 10 years ago

@laradji i'm not sure if I can contribute to this project any longer. I've changed jobs and need to go through some talks with the legal department to see if its ok. Employment IP agreements can be pretty draconian in the US (often times companies can claim rights on things you do on your own machine when not on work hours).

laradji commented 10 years ago

@andrewGarson too bad you help is welcome here :) Do you have gtalk account so we can stay in touch ?