search

laradji / zabbix

Zabbix chef cookbook
Apache License 2.0
91 stars 125 forks source link

host resource and host providers are out-of-sync #173

Closed nightw closed 10 years ago

nightw commented 10 years ago

The resources/host.rb file contains attributes for groups, templates and interfaces, but those are currently ignored in the providers/host.rb, since that file is only using the parameters[:groupNames], parameteres[:templates] and parameteres[:interfaces] attribute respectively for registering a host to the Zabbix server.

I've created a pull request: #174 fixing this issue while I tried to keep the backward compatibility to not brake the agent_registration recipe and other people's application cookbooks using this resource the old way. Could you please review it?

laradji commented 10 years ago

@guilhem your the best to validate PR for this part of the cookbook.

guilhem commented 10 years ago

Close it in favor of discussion in PR itself