search

laradji / zabbix

Zabbix chef cookbook
Apache License 2.0
91 stars 124 forks source link

Move interface ports to attributes and fix NME problem in autoreg #183

Closed swalberg closed 10 years ago

swalberg commented 10 years ago

This PR improves the agent autoregistration to allow the ports to be set. My primary use was to set the JMX port, but I also allowed for the Zabbix agent and snmp ports to be overridden. The defaults keep the same behaviour as originally hard-coded.

At the same time I applied https://github.com/MurgaNikolay/zabbix/commit/23b79c38293f4515a4ba421722d73e4f25f6acfc which fixes a bug in the agent autoregistration. interfaces is an array and doesn't support the values method.

laradji commented 10 years ago

Hi there @swalberg , thank you for the PR.

I'm ok with your patch, @guilhem can you +1 too ?

guilhem commented 10 years ago

Seems fine to me.