Closed swalberg closed 10 years ago
This PR improves the agent autoregistration to allow the ports to be set. My primary use was to set the JMX port, but I also allowed for the Zabbix agent and snmp ports to be overridden. The defaults keep the same behaviour as originally hard-coded.
At the same time I applied https://github.com/MurgaNikolay/zabbix/commit/23b79c38293f4515a4ba421722d73e4f25f6acfc which fixes a bug in the agent autoregistration. interfaces is an array and doesn't support the values method.
interfaces
values
Hi there @swalberg , thank you for the PR.
I'm ok with your patch, @guilhem can you +1 too ?
Seems fine to me.
This PR improves the agent autoregistration to allow the ports to be set. My primary use was to set the JMX port, but I also allowed for the Zabbix agent and snmp ports to be overridden. The defaults keep the same behaviour as originally hard-coded.
At the same time I applied https://github.com/MurgaNikolay/zabbix/commit/23b79c38293f4515a4ba421722d73e4f25f6acfc which fixes a bug in the agent autoregistration.
interfaces
is an array and doesn't support thevalues
method.