Fix the database dependencies

laradji / zabbix

Zabbix chef cookbook

Apache License 2.0

91 stars 125 forks source link

Fix the database dependencies #198

Open chewi opened 9 years ago

chewi commented 9 years ago

Don't include MySQL recipes when not using MySQL.
Don't include mysql::client at all, database::mysql is sufficient.
Do include database::postgresql when using PostgreSQL.
Bump database dependency due to breaking changes in mysql-chef_gem.
Demote mysql and postgresql cookbooks to "suggests" as they are not strictly required.

j-miyake commented 9 years ago

vermut commented 9 years ago

Latest "database" seems to completely break everything. Maybe we should limit it with the 2.3.1?

chewi commented 9 years ago

Can you elaborate please?

vermut commented 9 years ago

For example, there is no database::mysql in latest database cookbook

And current zabbix::database directly calls it.

chewi commented 9 years ago

It was good up until 4.0.2. It has disappeared for a good reason though. The mysql2_chef_gem cookbook should now be used. This change explains the situation quite well.

vermut commented 9 years ago

I agree completely. But current laradji/zabbix/master is not adapted for a change. That's why I proposed to limit database to 2.3.1 or any latest working version.

Because berkshelf will pull mysql-6.x and database-5.x from current config and it will never work.