search

laradji / zabbix

Zabbix chef cookbook
Apache License 2.0
91 stars 124 forks source link

Fix port-assignment for apache #199

Closed junjihashimoto closed 9 years ago

junjihashimoto commented 9 years ago

When web-server is apache, node['zabbix']['web']['port'] is not used. Add port-assignment.

laradji commented 9 years ago

Hi @junjihashimoto,

Thank you for your PR. can you please create a default value in attribute file ?

Regards,

junjihashimoto commented 9 years ago

I think the default value already exits. https://github.com/laradji/zabbix/blob/master/attributes/web.rb#L6

Please tell me if I'm mistaking the meaning of the request.

laradji commented 9 years ago

Good catch @guilhem , it's weird that we don't use it.

junjihashimoto commented 9 years ago

thx

guilhem commented 9 years ago

Weird indeed ^^