search

laradji / zabbix

Zabbix chef cookbook
Apache License 2.0
91 stars 125 forks source link

Added screen resource with provider, supporting the usual actions #202

Open nightw opened 9 years ago

nightw commented 9 years ago

About half a year ago I've already submitted this change and ( #177 ) and @guilhem asked for a test for this. I've not provided it back then for a long time, so the Pull Request got closed without merging it. Sorry for taking so long, here is the change with a test case attached to it. :)

The test case is a bit big (installs MySQL, Zabbix, Zabbix web, etc. to be able to use the API for the LWRP), very specific (only works using Ubuntu 14.04 because of some package/cookbook breaking changes), but if it does not break, that means the screen resource could be created with this LWRP using the Zabbix API.

Please review (and run the test) and if you find it appropriate then merge it. Thanks.

nightw commented 9 years ago

Also corrected the RuboCop offenses. Now the test fails for some reason on Ruby 1.9 during bundle install, so it's not related to this pull request (and should be fixed separately). On Ruby2.0 the test passes.

nightw commented 8 years ago

Could you please review this?