search

laraedit / laraedit-docker

Dockerized version of Laravel Homestead
MIT License
450 stars 78 forks source link

disable xdebug for composer only #18

Open ibourgeois opened 8 years ago

ibourgeois commented 8 years ago

it would be great to have xdebug disabled for composer only to increase speed when using composer.

vitr commented 8 years ago

this is from homestead

# Disable XDebug On The CLI
sudo phpdismod -s cli xdebug
ibourgeois commented 8 years ago

@vitr would you be able to put in a pull request to the dev branch with this so you get credit for it? Thanks

vitr commented 8 years ago

sure, I noticed, this is the only command with sudo in your Dockerfile https://github.com/laraedit/laraedit-docker/pull/40

ibourgeois commented 8 years ago

The container uses root, so sudo shouldn't be necessary. I accepted your pull request and dropped sudo.

As soon as the build is complete on the dev branch, I will merge with master. Thanks for your help!