larainezo / pe

0 stars 0 forks source link

Initial default appointments still show even after deleting the appointments file #3

Open larainezo opened 4 months ago

larainezo commented 4 months ago

Steps to reproduce

Step 1: Delete the appointmentList JSON file

image.png

Step 2: Run java -jar "[CS2103-F08-2][CogniCare].jar"

I gave this bug a medium severity level because we can still delete the appointments manually in CogniCare, but I was wondering that some users may opt to delete the entire JSON file for efficiency.

Expected There should not be any appointments shown in CogniCare when it is launched.

Actual Default appointments added when CogniCare was launched again were shown.

Screenshots image.png

nus-se-script commented 4 months ago

Team's Response

This is the intended behaviour, because the application uses the default appointment list if the system detects there is no corresponding JSON file. If the user wants to delete all appointments, they should delete all data inside the JSON file instead

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for explaining. However, I feel that users may not know to delete the data inside the JSON file instead. In fact, I believe that this is the danger of having 2 separate files as well. Instead, the appointments and patients lists could have been placed in the same JSON file.

Additionally, there should be a warning somewhere to let the user know of the risks of deleting the appointment file when there is still a patient file.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Issues should only be given a very low severity level if it is a cosmetic issue. I disagree that this should be considered one because it is related to the functionality of CogniCare and not just a formatting issue. ![image.png](https://raw.githubusercontent.com/larainezo/pe/main/files/f5db24b9-73e4-4819-9e26-f528e5b1f44c.png)