search

laravel-ardent / ardent

Self-validating, secure and smart models for Laravel's Eloquent ORM
BSD 3-Clause "New" or "Revised" License
1.39k stars 211 forks source link

Ardent upgrades causing SegFault #288

Open wwendorf opened 8 years ago

wwendorf commented 8 years ago

I'm afraid my post won't be all that useful, more of an FYI.

I use ardent instead of eloquent on most of my models, and 2.5.0 wouldn't even access my database.

There were no errors at all except a segmentation fault in the apache error log.

Feel free to contact me if you need more details as I now know how to replicate it. I had to drop from 2.5.0 back to 2.4.2 to get my app working again.

Wade

igorsantos07 commented 8 years ago

Would you please elaborate on how the issue happened?

Also, have you tried the newer versions, like the 3.x branch?

Igor Santos -- Desenvolvedor Web [enviado do meu celular] On 10 Dec 2015 21:19, "Wade Wendorf" notifications@github.com wrote:

I'm afraid my post won't be all that useful, more of an FYI.

I use ardent instead of eloquent on most of my models, and 2.5.0 wouldn't even access my database.

There were no errors at all except a segmentation fault in the apache error log.

Feel free to contact me if you need more details as I now know how to replicate it. I had to drop from 2.5.0 back to 2.4.2 to get my app working again.

Wade

— Reply to this email directly or view it on GitHub https://github.com/laravel-ardent/ardent/issues/288.

wwendorf commented 8 years ago

I can elaborate as much as possible as I got no errors. I have a laravel 4.1 app, and I had to update another libary. After update, the app wouldn't work at all. The only error message I got was in relation to the apache error.log and I got a segmentation fault. I had to basically put Log::info("break") in every line in my app thru the progression of my code to find out where the app was failing. It turned to to be any model that used Ardent. To test my theory, I write a quick lookup in the routes file on my user table. It never made a DB connection and just failed. When I switched the model to Eloquent, I got results. I then looked back to see that I had been using 2.4.2, but my composer json was set to 2., so it upgraded it to 2.5.0, which failed horribly (as I described above). When I finally found out what was killing my app, I then changed composer json to 2.4. and ran the update again, which downgraded Ardent to 2.4.2 and everything started working again.

I'm unable to use 3.* because it's apparently in need of Larvel 5.* which I can't justify the time to upgrade the entire app to as there are far to many changes that would have to be made.

Wade

On Fri, Dec 11, 2015 at 8:38 AM, Igor Santos notifications@github.com wrote:

Would you please elaborate on how the issue happened?

Also, have you tried the newer versions, like the 3.x branch?

Igor Santos -- Desenvolvedor Web [enviado do meu celular] On 10 Dec 2015 21:19, "Wade Wendorf" notifications@github.com wrote:

I'm afraid my post won't be all that useful, more of an FYI.

I use ardent instead of eloquent on most of my models, and 2.5.0 wouldn't even access my database.

There were no errors at all except a segmentation fault in the apache error log.

Feel free to contact me if you need more details as I now know how to replicate it. I had to drop from 2.5.0 back to 2.4.2 to get my app working again.

Wade

— Reply to this email directly or view it on GitHub https://github.com/laravel-ardent/ardent/issues/288.

— Reply to this email directly or view it on GitHub https://github.com/laravel-ardent/ardent/issues/288#issuecomment-163950887 .

lukasbesch commented 8 years ago

I can confirm this issue using Ardent 3.3.0 and Laravel 5.2.12. I tried using other Ardent Versions but no luck for me.

Background: I just got a Laravel 4 site (4.0.x-dev from the composer.json) which runs on PHP 5.3 using Ardent 2.1.0. This is on production and working. My job is to update the site to the latest stable version to make it work on PHP 5.6 and up. So I cloned the repository and migrated all the application files and stuff to a fresh Laravel 5 project, updated dependencies and stuff and it looks good for now, except certain pages on which Models using Ardent are used. I tried to debug the core dump with gdb but I really don't know what I am doing there ;-)

Like in Wade's case if I switch to the Eloquent model no segmentation faults are thrown.

igorsantos07 commented 8 years ago

This is the weirdest thing I've ever seen in PHP. Never had a segfault using PHP.

So, the issue is happening on Laravel 4.1 changing Ardent from 2.4.2 to 2.5.0 with @wwendorf, and Laravel 5.2 and Ardent 3.3 after an upgrade from Laravel 4 and Ardent 2.1 by @lukasbesch, right?

This is the diff between the versions that worked and affected @wwendorf. It would be very, very kind if anyone could review those changes and see if there's something strange. Also, Wade, what else you had to update? Any chance you've updated the PHP version as well? :)

However, I can't get any idea on the second case; as you said, it's a brand new application on Laravel 5, right? It shouldn't bring any trouble.

Would you both mind getting some info from gdb, as explained here? It kinda points out where the issue happened, then we can look at it and try to figure out the relation with Ardent/Laravel.

Ardakilic commented 8 years ago

I can confirm this also happens on Laravel 4.1.31 along with Ardent 2.5.0 on Ubuntu Server 14.04 x64, downgrading to 2.4.2 fixed the problem.