search

laravel-ardent / ardent

Self-validating, secure and smart models for Laravel's Eloquent ORM
BSD 3-Clause "New" or "Revised" License
1.39k stars 211 forks source link

Laravel 5.7 Issue #312

Closed lloricode closed 5 years ago

lloricode commented 5 years ago

Hi!, after installing laravelbook/ardent:dev-master through composer, there is an issue


In ArdentServiceProvider.php line 22:

  Call to undefined method LaravelArdent\Ardent\Providers\ArdentServiceProvid
  er::package()
igorsantos07 commented 5 years ago

Would you try 3.4.* and see if it persists? I'm thinking #305 included something that's not used anymore - the said service provider...

lloricode commented 5 years ago

@igorsantos07 thanks, it works now, but can we fix this to get the latest updates?

lloricode commented 5 years ago

we need this https://github.com/laravel-ardent/ardent/pull/310/files,

screenshot from 2018-10-09 10-09-54

lloricode commented 5 years ago

i think we need to have a new PR to fix this?

igorsantos07 commented 5 years ago

@lloricode check 3.6.0. Hopefully, it'll solve the matter and not break the code, as I've removed two files without being able to test them. You tested one, the other was the Facade (which I'm pretty sure I never used), so we're good to go?

lloricode commented 5 years ago

@igorsantos07 thanks, i will check that :)