search

laravel-at / laravel-image-sanitize

Prevent malicious code execution through uploaded image files
MIT License
229 stars 16 forks source link

alias ImageSanitize::class to 'image-sanitize' #3

Closed chapeupreto closed 5 years ago

chapeupreto commented 5 years ago

This PR fixes ImageSanitizeFacade by aliasing ImageSanitize::class to image-sanitize.

Also, tests considering Facade usage were written.

koenhoeijmakers commented 5 years ago

I would like to add my 2 cents and say that it's probably better to change the facade accessor to return ImageSanitize::class

nuernbergerA commented 5 years ago

@chapeupreto thanks for your PR we will take a look at it later due to lack of time.

chapeupreto commented 5 years ago

@koenhoeijmakers Totally agree with you. Thanks! @nuernbergerA No worries. I'm gonna close this PR and open another one soon. Also, this time I think it'd be better to have a separate file for the Facade tests.