search

laravel-doctrine / fluent

Fluent mapping driver for Doctrine2
http://www.laraveldoctrine.org/docs/current/fluent
MIT License
43 stars 22 forks source link

doctrine/orm version bump #75

Closed dpgover closed 2 years ago

dpgover commented 2 years ago

@eigan For this package to work with Laravel 9, doctrine/inflector needs to be used in version 2.0 at least. Version 1.4 changed the API and the old one is deprecated.

I left a PR for this: #74

Also, this package is requiring multiple doctrine/orm versions, while laravel-doctrine/orm is only requiring ^2.6. Do you think we can change the requirements on composer.json to be alligned?

eigan commented 2 years ago

Thanks @dpgover! Looks good.

Change to ^2.6 is a good idea.

Could you update https://github.com/laravel-doctrine/fluent/blob/1.x/.github/workflows/ci.yml too? Add 2.10 and 2.11 :)

dpgover commented 2 years ago

I have the chages in another branch on my fork. I'll make another PR for that then. Have in mind that the change requires dbal 2.12.x or 3.x.

dpgover commented 2 years ago

Done.

@eigan see #76 with the changes for doctrine/inflector and doctrine/orm.

We are trying to upgrade to Laravel 9, so a new release will be really appreciated :)

eigan commented 2 years ago

Sorry for the delay. Was on vacation. Will release this soon (within 24 hours)

eigan commented 2 years ago

Released now as 1.3, thanks!

dpgover commented 2 years ago

🔥 🚀 🎉