laravel-doctrine / orm

An integration library for Laravel and Doctrine ORM
MIT License
829 stars 177 forks source link

[FEATURE] Add driver options to all drivers #556

Closed keithbrink closed 1 year ago

keithbrink commented 1 year ago

Continuing with #260, this provides support for setting driver options on all connection drivers.

This also aligns the setting with Laravel's setting, using "options" in the config rather than "driverOptions" (link).

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (ad94c82) 66.88% compared to head (2302d35) 66.92%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.0 #556 +/- ## ============================================ + Coverage 66.88% 66.92% +0.03% Complexity 563 563 ============================================ Files 83 83 Lines 1806 1808 +2 ============================================ + Hits 1208 1210 +2 Misses 598 598 ``` | [Impacted Files](https://app.codecov.io/gh/laravel-doctrine/orm/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/Configuration/Connections/MysqlConnection.php](https://app.codecov.io/gh/laravel-doctrine/orm/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0NvbmZpZ3VyYXRpb24vQ29ubmVjdGlvbnMvTXlzcWxDb25uZWN0aW9uLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Configuration/Connections/PgsqlConnection.php](https://app.codecov.io/gh/laravel-doctrine/orm/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0NvbmZpZ3VyYXRpb24vQ29ubmVjdGlvbnMvUGdzcWxDb25uZWN0aW9uLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Configuration/Connections/SqliteConnection.php](https://app.codecov.io/gh/laravel-doctrine/orm/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0NvbmZpZ3VyYXRpb24vQ29ubmVjdGlvbnMvU3FsaXRlQ29ubmVjdGlvbi5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Configuration/Connections/SqlsrvConnection.php](https://app.codecov.io/gh/laravel-doctrine/orm/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0NvbmZpZ3VyYXRpb24vQ29ubmVjdGlvbnMvU3Fsc3J2Q29ubmVjdGlvbi5waHA=) | `90.90% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eigan commented 1 year ago

I think the configuration here follows the keys from https://www.doctrine-project.org/projects/doctrine-dbal/en/current/reference/configuration.html, not sure if should rename this setting, as Laravel is never involved anyway. Does the other keys match laravel settings?

keithbrink commented 1 year ago

@eigan Yeah, the other keys are following Laravel's key names:

dbname -> database user -> username

eigan commented 1 year ago

Thanks!