laravel-doctrine / orm

An integration library for Laravel and Doctrine ORM
MIT License
829 stars 177 forks source link

[FIX] selectCount() does not exists. maybe: select() #559

Closed 77web closed 1 year ago

77web commented 1 year ago

validation rules like exists:App\Entities\Foo,1 does not work after https://github.com/laravel-doctrine/orm/commit/57612a2aefbda6572760a4e322b424b15eb072cc

Changes proposed in this pull request:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f5fcab7) 66.88% compared to head (ab56c04) 66.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.0 #559 +/- ## ========================================= Coverage 66.88% 66.88% Complexity 563 563 ========================================= Files 83 83 Lines 1806 1806 ========================================= Hits 1208 1208 Misses 598 598 ``` | [Files Changed](https://app.codecov.io/gh/laravel-doctrine/orm/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/Validation/DoctrinePresenceVerifier.php](https://app.codecov.io/gh/laravel-doctrine/orm/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL1ZhbGlkYXRpb24vRG9jdHJpbmVQcmVzZW5jZVZlcmlmaWVyLnBocA==) | `91.66% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eigan commented 1 year ago

Typo, thanks! 🙈