Help disable eslint checks

[adithewonderboy]

This is a help request.

Prerequisites

• [x ] Are you running the latest version?
• [ x] Are you reporting to the correct repository? (enso is made of many specialized packages: https://github.com/laravel-enso)
• [ x Did you check the documentation?
• [x ] Did you perform a cursory search?

Description

The Eslint checks are giving us a lot of errors especially with line endings, curly braces, line length and so on. Is there an easy way to disable eslint from doing this? .eslintignore file seems to be ignored. Also modifying the eslint rules doesn't seem to do the trick either...

Steps to Reproduce

1. Update to enso 3.7.2
2. Build the assets
3. Yarn watch
4. Change some .vue or .js files
5. In many cases eslint raises errors and the build crashes

Expected behavior

We want to disable eslint and use our project code formatting.

Actual behavior

Eslint complains about formatting and the builds are constantly crashing.

[mauthi]

You can call the linting with --fix - then most of the errors are fixed automatically. (I had 1.300 errors and the --fix solved ~1.220 of them)

[adithewonderboy]

Yes, I already tried that, and the build is ok but when I run "yarn build--watch" and change one file, then is constantly crashing again.., even if I try also with "yarn build --watch --fix"

[mauthi]

I think it should be changed from errors to warnings - but I'm also beginner in this topic.

[adithewonderboy]

I already tried that in eslintrc file but it didn't work, because many rules are inherited from vue itself.

On Fri, 22 Nov 2019, 12:09 mauthi, notifications@github.com wrote:

I think it should be changed from errors to warnings - but I'm also beginner in this topic.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel-enso/enso/issues/270?email_source=notifications&email_token=AN23K2QEVFRSRQ6H722Y223QU6VXBA5CNFSM4JQOJXF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE5FZKY#issuecomment-557472939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN23K2RQJVAYXW6T5NLDADLQU6VXBANCNFSM4JQOJXFQ .

[aocneanu]

You will have to modify (in sync) both eslint files and setup your personal rules. The one in the root folder, used by editors, and the one in under the client folder used by vue cli service.

[aocneanu]

Regarding the rules inherited from vue, it was one of the main reasons why it took so long for us to migrate on vue cli. But eventually we conformed with them.

[adithewonderboy]

You will have to modify (in sync) both eslint files and setup your personal rules. The one in the root folder, used by editors, and the one in under the client folder used by vue cli service.

Thanks for this explanation, I did not understand from the documentation which eslint file is used or not and for what purpose. Can you add this mention on documentation also? It can save a lot of time for any others that have these issues. I spent precious time trying to understand why my rules are working in some cases and not working in other ones

[aocneanu]

@gandesc please add a mention regarding this in docs.

[adithewonderboy]

Thank you!

On Fri, 22 Nov 2019, 12:51 Adrian Ocneanu, notifications@github.com wrote:

@gandesc https://github.com/gandesc please add a mention regarding this in docs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel-enso/enso/issues/270?email_source=notifications&email_token=AN23K2T5YP7BUNMAJX4QRELQU62TBA5CNFSM4JQOJXF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE5JCAA#issuecomment-557486336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN23K2SH2WF3CKDGNHDLABLQU62TBANCNFSM4JQOJXFQ .